[5.3] Admin: Contact view does not load with a large user base #44600
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BrianTeeman <[email protected]>
|
I have tested this item ✅ successfully on f5db2d4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44600. |
|
I have tested this item ✅ successfully on f5db2d4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44600. |
1 similar comment
|
I have tested this item ✅ successfully on f5db2d4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44600. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44600. |
|
I know this is more a user backwards compatibility break and doesn't fall into our bc policy. If necessary I would like to remove stuff only in a major version, except when it is urgent, which is here not the case. An admin can do a layout override now till 6.0 is released. |
|
I disagree. This is a bug fix. Telling someone to create an override to fix a bug is not the correct thing to do. As per the original bug report this useless function prevents the correct operation of anything in the com_contact list view as the query is run on page load and not just when the modal opens |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #41187 .
Summary of Changes
This PR removes the ability when using batch functions to set/change the linked user. As this loads all users on the site into a giant list it impacts performance of all functionality in the contact component list view. With enough users it can even prevent the page from loading.
I can't see a valid use case for even having the functionality to link multiple contacts to the same user.
The field to select the users is therefore removed from the batch modal and the related files and strings are therefore marked as deprecated without replacement
Testing Instructions
Open the batch modal for the contact manager
Actual result BEFORE applying this Pull Request
Option to mass set linked user
Expected result AFTER applying this Pull Request
Option no longer present
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed